Torch add invert and split #1112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are missing tests; will add a small one soon ™️ |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
- Coverage 82.10% 82.10% -0.01%
==========================================
Files 185 185
Lines 48089 48097 +8
Branches 8659 8659
==========================================
+ Hits 39485 39489 +4
- Misses 6439 6443 +4
Partials 2165 2165
|
ricardoV94
reviewed
Dec 9, 2024
|
|
||
| @pytorch_funcify.register(Split) | ||
| def pytorch_funcify_Split(op, node, **kwargs): | ||
| def inner_fn(x, dim, split_amounts): |
There was a problem hiding this comment.
A more descriptive name is nice because it shows in the compiled function
There was a problem hiding this comment.
Yea your totally right
|
I'm about to merge another PR that contains these and a test. I'll close this out for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These ops were needed to verify the pymc model in #1110
Related Issue
Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1112.org.readthedocs.build/en/1112/