Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some UserWarnings #6407

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Conversation

ricardoV94
Copy link
Member

Closes #6401

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #6407 (1c1695e) into main (6ab0c03) will decrease coverage by 7.68%.
The diff coverage is 98.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6407      +/-   ##
==========================================
- Coverage   94.78%   87.10%   -7.68%     
==========================================
  Files         148      148              
  Lines       27678    27716      +38     
==========================================
- Hits        26234    24142    -2092     
- Misses       1444     3574    +2130     
Impacted Files Coverage Δ
pymc/tests/distributions/test_timeseries.py 99.52% <92.30%> (+<0.01%) ⬆️
pymc/backends/arviz.py 96.37% <100.00%> (ø)
pymc/distributions/logprob.py 100.00% <100.00%> (ø)
pymc/distributions/timeseries.py 94.52% <100.00%> (+0.05%) ⬆️
pymc/logprob/abstract.py 97.59% <100.00%> (+0.02%) ⬆️
pymc/tests/backends/test_arviz.py 99.04% <100.00%> (+0.01%) ⬆️
pymc/tests/distributions/test_logprob.py 100.00% <100.00%> (ø)
pymc/tests/distributions/test_continuous.py 0.00% <0.00%> (-99.78%) ⬇️
pymc/tests/distributions/test_multivariate.py 36.44% <0.00%> (-63.01%) ⬇️
pymc/distributions/multivariate.py 57.77% <0.00%> (-34.51%) ⬇️
... and 6 more

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arviz part looks good, thanks

@ricardoV94 ricardoV94 marked this pull request as draft December 21, 2022 21:10
@michaelosthege
Copy link
Member

@ricardoV94 is there any more work needed, or can the draft status be removed?

@ricardoV94
Copy link
Member Author

This still needs work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: RandomWalk/joint_logprob spam warnings about non-contributing RVs in the graph
3 participants