Partially revert #5131 #5135
Merged
Partially revert #5131 #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Metropolis proposals to depend on global seeding by default
Codecov Report
@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
- Coverage 77.74% 77.74% -0.01%
==========================================
Files 88 88
Lines 14100 14098 -2
==========================================
- Hits 10962 10960 -2
Misses 3138 3138
|
twiecki
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-allows Metropolis proposals to depend on global seeding by default.
Unfortunately the sampling/step API (and test suite) is strongly dependent on global random seeding. I am partially reverting some changes from #5131, which led to flaky tests.
Closes #5134