Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -1 to indicate dynamically sized dimensions #85

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Feb 18, 2023

Strictly speaking the change of data type in the protobuf is bad practice, but the package is still in 0.x versions so there's that.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Base: 95.79% // Head: 96.07% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (0d6fa20) compared to base (6a75046).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   95.79%   96.07%   +0.28%     
==========================================
  Files           9        9              
  Lines         642      637       -5     
==========================================
- Hits          615      612       -3     
+ Misses         27       25       -2     
Impacted Files Coverage Δ
mcbackend/__init__.py 77.77% <100.00%> (+6.34%) ⬆️
mcbackend/core.py 87.21% <100.00%> (ø)
mcbackend/meta.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michaelosthege michaelosthege marked this pull request as ready for review February 19, 2023 13:43
@michaelosthege michaelosthege merged commit b8246a3 into main Feb 19, 2023
@michaelosthege michaelosthege deleted the allow0shape branch February 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants