Update setuptools to >=71.0.4 #9812
Conversation
cdce8p
added
Skip news 🔇
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9812 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 174 174
Lines 18902 18902
=======================================
Hits 18107 18107
Misses 795 795 |
This comment has been minimized.
This comment has been minimized.
| @@ -9,4 +9,4 @@ pytest-timeout~=2.3 | |||
| towncrier~=23.11 | |||
| requests | |||
| # Voluntary for test purpose, not actually used in prod, see #8904 | |||
| setuptools==41.6.0 | |||
| setuptools;python_version>='3.12' | |||
There was a problem hiding this comment.
I'm in favor of removing the version pin, but can I ask why limit the python version?
There was a problem hiding this comment.
Until 3.12, setuptools was bundled with Python itself.
There was a problem hiding this comment.
This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.
There was a problem hiding this comment.
Got it, I must manually uninstalled it to reproduce that issue 😅
There was a problem hiding this comment.
This is the test dependencie set to this specific version as a regression test (see comment above) I think the threat reported is not applicable in this case.
I think so too. It nevertheless is a good idea to install a more modern version of setuptools and not keep the old one around. Especially as everyone has moved on since.
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on pytest:
This comment was generated for commit 135f165 |
(cherry picked from commit 60bd230)
(cherry picked from commit 60bd230)
Description
Update setuptools version used for tests and build.
Fixes https://github.com/pylint-dev/pylint/security/dependabot/2
https://setuptools.pypa.io/en/latest/history.html#v71-0-4