Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent stats loss #9082

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Sep 30, 2023

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #9059

Some messages are emitted before the checkers are opened, so this was clearing stats too soon.

@jacobtylerwalls jacobtylerwalls added this to the 3.0.0 milestone Sep 30, 2023
@jacobtylerwalls jacobtylerwalls marked this pull request as ready for review September 30, 2023 17:22
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #9082 (01ca7ff) into main (881e6bc) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9082      +/-   ##
==========================================
- Coverage   95.75%   95.75%   -0.01%     
==========================================
  Files         173      173              
  Lines       18664    18663       -1     
==========================================
- Hits        17872    17871       -1     
  Misses        792      792              
Files Coverage Ξ”
pylint/lint/pylinter.py 96.22% <ΓΈ> (-0.01%) ⬇️

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit 01ca7ff

@jacobtylerwalls jacobtylerwalls merged commit 9c69801 into pylint-dev:main Oct 1, 2023
46 checks passed
@jacobtylerwalls jacobtylerwalls deleted the fix-stats branch October 1, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Score, fail-on, fail-under, etc ignores messages emitted by PyLinter itself
3 participants