Fix crash from unexpected assignment #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8839 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 173 173
Lines 18508 18508
=======================================
Hits 17744 17744
Misses 764 764
|
jacobtylerwalls
added
Crash π₯
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 5bdeb08 |
jacobtylerwalls
approved these changes
Jul 12, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.17.x maintenance/2.17.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.17.x
# Create a new branch
git switch --create backport-8839-to-maintenance/2.17.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e71f63b5ec623b5c128891453baf2bea63fa6eff
# Push it to GitHub
git push --set-upstream origin backport-8839-to-maintenance/2.17.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.17.xThen, create a pull request where the |
jacobtylerwalls
pushed a commit
to jacobtylerwalls/pylint
that referenced
this pull request
Jul 12, 2023
(cherry picked from commit e71f63b)
jacobtylerwalls
added a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
A short fix for a rare case that causes a fatal error, due to illegal attribute access of the
AssignAttrnode.From my understanding, the relevant logic is supposed to check for the existence of an assignment that defines and uses the same variable, like
x = x. LHS should always beAssignNamenode.Closes #8754