-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyreverse: Use dashed lines for type-checking imports #8824
Merged
Pierre-Sassoulas
merged 18 commits into
pylint-dev:main
from
nickdrozd:pyreverse-package-type-checking
Jul 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bec61ff
Pyreverse: Use empty arrows for type-checking imports
nickdrozd 1a2b998
Use dashed lines instead of empty arrows
nickdrozd 614354e
Simplify branch logic
nickdrozd 95663f9
Start test
nickdrozd 458a737
Add mermaid writer
nickdrozd 3701040
move test data
nickdrozd 3bb5b2c
add config fixtures
nickdrozd 59b5ba1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 611a353
get test data from right place
nickdrozd dc30497
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5dd3831
Cut KeyError check
nickdrozd afb4632
Add news
nickdrozd b6d2cc5
Add uml
nickdrozd 94c99bc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 49d5e25
Bring back KeyError check
nickdrozd 20d47fe
Skip KeyError coverage
nickdrozd 4057067
Rename type dependency
nickdrozd abcfcc2
Cut type_check_imports_dot_config
nickdrozd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines are uncovered, and I don't know how to cover them. Any ideas? They could also be cut, or just ignore the coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check is definitely required. But I can't figure out exactly what triggers it.