Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cyclic-import message with --jobs #8807

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #4171

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #8807 (61f551f) into main (d203de7) will increase coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head 61f551f differs from pull request most recent head fac0949. Consider uploading reports for the commit fac0949 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8807      +/-   ##
==========================================
+ Coverage   95.87%   95.89%   +0.01%     
==========================================
  Files         173      173              
  Lines       18503    18510       +7     
==========================================
+ Hits        17740    17750      +10     
+ Misses        763      760       -3     
Impacted Files Coverage Ξ”
pylint/checkers/imports.py 94.18% <87.50%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't understand why we cover the reduce without covering the get_map_data.. Should we pragma: no cover it ?

@jacobtylerwalls
Copy link
Member Author

I verified that the line is being hit, but it's hit during parallel processing, so there could be a bug in codecov. Let's not add a pragma for something that's a bug in codecov.

@Pierre-Sassoulas
Copy link
Member

The [skip ci] in the terminal commit prevent the CI from running properly.

@jacobtylerwalls
Copy link
Member Author

The [skip ci] in the terminal commit prevent the CI from running properly.

I did it on purpose to avoid wasting resources on linting a commit that removed lines from an RST file. I'll just override :-)

@jacobtylerwalls
Copy link
Member Author

Also, GitHub was not showing additional commits this morning, I opened a bug report with them and they just said "it happens sometimes" and didn't show it on githubstatus or anything.

@jacobtylerwalls jacobtylerwalls merged commit bf8051b into pylint-dev:main Jun 30, 2023
@jacobtylerwalls jacobtylerwalls deleted the cyclic-import-jobs branch June 30, 2023 20:45
@jacobtylerwalls
Copy link
Member Author

Also, the primer was failing on the first commit because the project cache was missing. It's possible that without frequent enough commits on main, the PRs will always fail because the needed cache gets evicted?

@Pierre-Sassoulas
Copy link
Member

I was wondering about the primer too. Funny that we would have an unusual drop in commit frequency and hitting never seen bugs πŸ˜„ (I blame the high temperatures, and the attention astroid is getting lately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No cyclic-import messages with jobs=0
3 participants