Regression fix for unused-variable false negative
#8684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8684 +/- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 172 172
Lines 18300 18302 +2
=======================================
+ Hits 17533 17535 +2
Misses 767 767
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
added
the
False Negative π¦
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
added
Unreleased
Skip news π
jacobtylerwalls
previously approved these changes
May 14, 2023
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 3bc94ee |
jacobtylerwalls
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
This is a fix for a false negative regression caused by #8441. The issue lies in
_defines_name_raises_or_returns(), which returns false even when an exception variable defines the given name.Closes #8595