[spelling] Ignore spelling in type/mypy type ignore comments #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enchant does not understand class name well enough so it creates false positives, and mypy type ignore comments with additional text are a syntax error anyway, so raising a spelling mistakes for it is not really important.
Pierre-Sassoulas
added
False Positive π¦
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8370 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 178 178
Lines 18766 18762 -4
==========================================
- Hits 17933 17929 -4
Misses 833 833
|
This comment has been minimized.
This comment has been minimized.
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 9c3b45f |
DanielNoord
approved these changes
Mar 2, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 2, 2023
enchant does not understand class name well enough so it creates false positives, and mypy type ignore comments with additional text are a syntax error anyway, so raising a spelling mistakes for it is not really important. (cherry picked from commit b5aab35)
Pierre-Sassoulas
added a commit
that referenced
this pull request
Mar 2, 2023
β¦8373) enchant does not understand class name well enough so it creates false positives, and mypy type ignore comments with additional text are a syntax error anyway, so raising a spelling mistakes for it is not really important. (cherry picked from commit b5aab35) Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
enchant does not understand class name well enough so it creates false positives, and mypy type ignore comments with additional text are a syntax error anyway, so raising a spelling mistakes for it is not really important.