Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry-core as a repository to prime #8193

Merged

Conversation

alexey-pelykh
Copy link
Contributor

I think this needs to go into main before the #8153 ?

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry labels Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #8193 (c4d9321) into main (cc76aa5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8193   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         177      177           
  Lines       18616    18616           
=======================================
  Hits        17785    17785           
  Misses        831      831           

@alexey-pelykh
Copy link
Contributor Author

So now the plan is to merge this, rebase the main PR and compare the results, right?

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :D Added bonus: the pipeline will run without us approving them, congratulation on becoming a contributor !

@Pierre-Sassoulas Pierre-Sassoulas merged commit afe867a into pylint-dev:main Feb 6, 2023
@alexey-pelykh alexey-pelykh deleted the feature/poetry-core-priming branch February 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants