Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 3.11 for Github actions #6551

Merged
merged 8 commits into from
Sep 30, 2022
Merged

Use 3.11 for Github actions #6551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4815e61
Use 3.11 for Github actions
Pierre-Sassoulas Jun 29, 2022
f8b9996
[github action] Upgrade cache version previous to dill upgrade
Pierre-Sassoulas Sep 25, 2022
7d6667d
[github action] Use the latest dill in the CI for 3.11-dev
Pierre-Sassoulas Sep 25, 2022
d517799
Use ``dill-pylint``
DanielNoord Sep 29, 2022
4c6c9ac
Like this then?
DanielNoord Sep 29, 2022
fd316f0
Some other fixes
DanielNoord Sep 29, 2022
593b591
Update doc/whatsnew/fragments/5920.other
Pierre-Sassoulas Sep 30, 2022
48ba923
Add classifier
DanielNoord Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ on:

env:
# Also change CACHE_VERSION in the other workflows
CACHE_VERSION: 27
DEFAULT_PYTHON: "3.10"
CACHE_VERSION: 29
DEFAULT_PYTHON: "3.11-dev"

jobs:
check-changelog:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
pull_request: ~

env:
CACHE_VERSION: 27
DEFAULT_PYTHON: "3.10"
CACHE_VERSION: 29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Sassoulas Btw, we could also make this a repository secret. It would mean that you need to update it in the settings, but it might be easier than having to do so in PRs every time.
Same goes for DEFAULT_PYTHON and PRE_COMMIT_CACHE.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather make it accessible for everyone for now because I don't want to freeze pylint development if I'm not available. It would help if PyCQA was more democratic and I could add you to the admin group.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but for some reason I feel like for pylint this is different. We also struggle with match ... case statements but we still support that version according to our classifier. For astroid I feel like we don't really introspect the ast fully but for pylint we do offer our current functionality completely on 3.11.
The objectives are a bit different, if you understand what I mean. But I'll leave this to you to decide!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're answering the other comment about package metadata ? Let's add the classifier then.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, my bad!

DEFAULT_PYTHON: "3.11-dev"
PRE_COMMIT_CACHE: ~/.cache/pre-commit

concurrency:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/primer-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
- ".github/workflows/primer-test.yaml"

env:
CACHE_VERSION: 27
CACHE_VERSION: 29

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand All @@ -26,7 +26,7 @@ jobs:
timeout-minutes: 5
strategy:
matrix:
python-version: [3.8, 3.9, "3.10"]
python-version: [3.8, 3.9, "3.10", "3.11-dev"]
outputs:
python-key: ${{ steps.generate-python-key.outputs.key }}
steps:
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
needs: prepare-tests-linux
strategy:
matrix:
python-version: [3.8, 3.9, "3.10"]
python-version: [3.8, 3.9, "3.10", "3.11-dev"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v3.0.2
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
needs: prepare-tests-linux
strategy:
matrix:
python-version: [3.8, 3.9, "3.10"]
python-version: [3.8, 3.9, "3.10", "3.11-dev"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v3.0.2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/primer_comment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

env:
# This needs to be the SAME as in the Main and PR job
CACHE_VERSION: 27
CACHE_VERSION: 29

permissions:
contents: read
Expand All @@ -37,7 +37,7 @@ jobs:
id: python
uses: actions/setup-python@v4.2.0
with:
python-version: "3.10"
python-version: "3.11-dev"

# Restore cached Python environment
- name: Restore Python virtual environment
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/primer_run_main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ concurrency:

env:
# This needs to be the SAME as in the PR and comment job
CACHE_VERSION: 27
CACHE_VERSION: 29

jobs:
run-primer:
Expand All @@ -25,7 +25,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
python-version: ["3.7", "3.10"]
python-version: ["3.7", "3.11-dev"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v3.0.2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/primer_run_pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ concurrency:

env:
# This needs to be the SAME as in the Main and comment job
CACHE_VERSION: 27
CACHE_VERSION: 29

jobs:
run-primer:
Expand All @@ -34,7 +34,7 @@ jobs:
timeout-minutes: 120
strategy:
matrix:
python-version: ["3.7", "3.10"]
python-version: ["3.7", "3.11-dev"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v3.0.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- published

env:
DEFAULT_PYTHON: "3.10"
DEFAULT_PYTHON: "3.11-dev"

jobs:
release-pypi:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- doc/data/messages/**

env:
CACHE_VERSION: 27
CACHE_VERSION: 29

jobs:
tests-linux:
Expand All @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, 3.8, 3.9, "3.10"]
python-version: [3.7, 3.8, 3.9, "3.10", "3.11-dev"]
outputs:
python-key: ${{ steps.generate-python-key.outputs.key }}
steps:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
needs: tests-linux
strategy:
matrix:
python-version: ["3.10"]
python-version: ["3.11-dev"]
env:
COVERAGERC_FILE: .coveragerc
steps:
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.10"]
python-version: ["3.11-dev"]
steps:
- name: Check out code from GitHub
uses: actions/checkout@v3.0.2
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, 3.8, 3.9, "3.10"]
python-version: [3.7, 3.8, 3.9, "3.10", "3.11-dev"]
steps:
- name: Set temp directory
run: echo "TEMP=$env:USERPROFILE\AppData\Local\Temp" >> $env:GITHUB_ENV
Expand Down
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/5920.other
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Pylint now provides basic support for Python 3.11.

Closes #5920
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ classifiers = [
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Topic :: Software Development :: Debuggers",
Expand All @@ -32,7 +33,9 @@ classifiers = [
]
requires-python = ">=3.7.2"
dependencies = [
"dill>=0.2",
# TODO: Remove dill-pylint once dill 0.3.6 is released
"dill>=0.2;python_version<'3.11'",
"dill-pylint>=0.3.6.dev0;python_version>='3.11'",
"platformdirs>=2.2.0",
# Also upgrade requirements_test_min.txt and all the CACHE_VERSION in
# github actions if you are bumping astroid.
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 3.0
envlist = formatting, py37, py38, py39, py310, pypy, benchmark
envlist = formatting, py37, py38, py39, py310, py311, pypy, benchmark
skip_missing_interpreters = true
requires = pip >=21.3.1
isolated_build = true
Expand Down