Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ArgumentsManager.help and deprecate load_command_line_configuration #6228

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Refactor ArgumentsManager.help and deprecate load_command_line_configuration #6228

merged 2 commits into from
Apr 11, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🔨 Refactoring

Description

Blocked by #6227.

@Pierre-Sassoulas I will be away this weekend without computer access. I'm just pushing the last two PRs I had prepared to fix the last deprecations in ArgumentsManager. If you want you can rebase and merge them as you see fit or wait for after the weekend 😄

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 7, 2022
@DanielNoord DanielNoord added this to the 2.14.0 milestone Apr 7, 2022
@DanielNoord DanielNoord added the Blocked 🚧 Blocked by a particular issue label Apr 7, 2022
@DanielNoord DanielNoord mentioned this pull request Apr 7, 2022
Merged
2 tasks
@coveralls
Copy link

coveralls commented Apr 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2147370954

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 93.994%
Totals Coverage Status
Change from base Build 2144911347: 0.09%
Covered Lines: 15885
Relevant Lines: 16900
💛 - Coveralls

@DanielNoord DanielNoord removed the Blocked 🚧 Blocked by a particular issue label Apr 11, 2022
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas This is ready for review and potential merge!

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit 9fe6b47 into pylint-dev:main Apr 11, 2022
@DanielNoord DanielNoord deleted the argparse-pylint-17 branch April 11, 2022 10:25
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas