-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade astroid to 2.9.1 #5529
Upgrade astroid to 2.9.1 #5529
Conversation
Potentially also fixes #1470? |
#1470 (comment) seems to indicate you're right, I'm going to see if I can add a regression test. |
727eca5
to
4f0c038
Compare
Pull Request Test Coverage Report for Build 1640750960
π - Coveralls |
Sadly my regression test do not fail with astroid 2.9.0. Did you manage to reproduce #1470 @DanielNoord ? I can't with pylint 2.12.2 and astroid 2.9.0 myself. |
I didn't look into it too much. The issue seems too have a fairly straightforward reproducible example, that doesn't crash any longer? |
Maybe... The issue is that my example / regression test does not crash with pylint 1.7.1 either. I guess having a symlink functional test isn't a bad thing though. |
This is a regression test for pylint-dev/astroid#1253 Closes #1470
4f0c038
to
c3767e6
Compare
Did we manage to make this regression test work? Or does it pass even with |
It pass even with 2.9.0, the symlink issue was actually happenning when the python installation was symlinked and not the analyzed code. But I think it's still a regression test for #1470 (the example is taken from here). Also a symlink functional tests can't hurt. |
Ah okay, so #1470 was resolved on |
I don't know if it's specifically in astroid 2.9.0 (or even in astroid, it could be pylint) but the issue was already fixed. |
Does |
I think so, it's stored as the link to another file (I used the relative link for this reason). Maybe you can confirm by checking out this branch and opening the symlinked files ? |
Nvm I think that |
Type of Changes
Description
Closes #1470
Closes #3499
Closes #4302
Closes #4798
Closes #5081