Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for crash on Compare node inference #5057

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Add test for crash on Compare node inference #5057

merged 5 commits into from
Oct 7, 2021

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Sep 21, 2021 •
edited
Loading

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

Fixed in pylint-dev/astroid#1185
Closes #5048

@DanielNoord DanielNoord added Regression Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable labels Sep 21, 2021
@DanielNoord DanielNoord added this to the 2.11.2 milestone Sep 21, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1316242958

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.179%
Totals Coverage Status
Change from base Build 1316171751: 0.0%
Covered Lines: 13537
Relevant Lines: 14528
💛 - Coveralls

@cdce8p cdce8p merged commit 066a184 into pylint-dev:main Oct 7, 2021
@DanielNoord DanielNoord deleted the regression-5048 branch October 7, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Crash 💥 A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable Regression
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

Crash 'AsStringVisitor' object has no attribute 'visit_unknown'
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @cdce8p