Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dataclasses #4967

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Sep 5, 2021

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

This closes #4963 and is based on the fix in pylint-dev/astroid#1165

Should this be added to the changelog? I didn't think so as it is fixed in astroid.

This closes pylint-dev#4963 and is based on the fix in PyCQA/astroid#41165
@Pierre-Sassoulas Pierre-Sassoulas added the Crash πŸ’₯ A bug that makes pylint crash label Sep 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Sep 5, 2021
@Pierre-Sassoulas
Copy link
Member

I think it's ok to not have a changelog when we just add a regression test following an astroid upgrade.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1232870442

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 189 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.01%) to 93.084%

Files with Coverage Reduction New Missed Lines %
pylint/extensions/empty_comment.py 1 96.55%
pylint/interfaces.py 1 96.97%
pylint/checkers/exceptions.py 2 96.41%
pylint/config/init.py 4 71.01%
pylint/extensions/docparams.py 4 97.7%
pylint/lint/pylinter.py 4 93.15%
pylint/message/message_handler_mix_in.py 8 95.33%
pylint/checkers/misc.py 10 82.67%
pylint/checkers/similar.py 14 96.35%
pylint/config/man_help_formatter.py 16 31.75%
Totals Coverage Status
Change from base Build 1201318317: -0.01%
Covered Lines: 13258
Relevant Lines: 14243

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit bc95cd3 into pylint-dev:main Sep 14, 2021
@DanielNoord DanielNoord deleted the dataclasses-1 branch September 14, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crash πŸ’₯ A bug that makes pylint crash Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash 'Call' object has no attribute 'value' when typing.cast is used on dataclass field
4 participants