Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression tests of inference of implicit None return #4428

Merged
merged 3 commits into from
May 30, 2021
Merged

Add regression tests of inference of implicit None return #4428

merged 3 commits into from
May 30, 2021

Conversation

nelfin
Copy link
Contributor

@nelfin nelfin commented May 1, 2021 •
edited
Loading

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

These errors are not currently raised on pylint 2.8.x and astroid 2.5.6

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Ref pylint-dev/astroid#485. Depends on pylint-dev/astroid#983.

@Pierre-Sassoulas Pierre-Sassoulas added the Enhancement ✨ Improvement to a component label May 1, 2021
@nelfin nelfin force-pushed the feature/infer-none-with-no-return branch from 87d0ae2 to cac4f1a Compare May 2, 2021 23:20
Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's pretty clean. I won't have to approve all your pipelines for much longer 😉

@cdce8p cdce8p mentioned this pull request May 22, 2021
Merged
2 tasks
@nelfin nelfin force-pushed the feature/infer-none-with-no-return branch from cac4f1a to 7a726e1 Compare May 24, 2021 08:36
@cdce8p cdce8p added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label May 24, 2021
@cdce8p cdce8p added this to the 2.8.3 milestone May 24, 2021
@nelfin
Update tests to return size from __len__
e445511 
No reason why they can't when it's relevant, instead of disabling this
warning
@nelfin nelfin force-pushed the feature/infer-none-with-no-return branch from 7a726e1 to e445511 Compare May 24, 2021 12:58
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 29, 2021
Merged
@Pierre-Sassoulas
Copy link
Member

This can be rebased on master to get astroid 2.5.7.

@cdce8p
Copy link
Member

cdce8p commented May 30, 2021

Part has been merged with #4523: 6f1ccd8

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.832% when pulling 060fb98 on nelfin:feature/infer-none-with-no-return into 6dec95b on PyCQA:master.

@cdce8p cdce8p merged commit 18151d1 into pylint-dev:master May 30, 2021
@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.8.3, 2.9.0 May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p left review comments

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component Needs astroid update Needs an astroid update (probably a release too) before being mergable
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nelfin @Pierre-Sassoulas @cdce8p @coveralls