[breaking changes] Add intention behind a possible fix #10618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10618 +/- ##
==========================================
- Coverage 95.96% 95.95% -0.01%
==========================================
Files 176 176
Lines 19470 19504 +34
==========================================
+ Hits 18684 18716 +32
- Misses 786 788 +2 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
previously approved these changes
Oct 6, 2025
pylint/config/_breaking_changes.py
Outdated
| [[Solution.REVIEW_OPTION]], | ||
| { | ||
| Intention.KEEP: [Solution.REVIEW_OPTION], | ||
| Intention.USE_DEFAULT: [], |
There was a problem hiding this comment.
Should this be DO_NOTHING?
There was a problem hiding this comment.
Yeap, definitely, great idea !
|
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit b250f6b |
jacobtylerwalls
approved these changes
Oct 6, 2025
Pierre-Sassoulas
temporarily deployed
to
Backport
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to #10612, realized that if we're letting the user choose we need some quick way to tell them what an option will do when they have to choose because "remove extension and disable message implicitly" is jargon we maintainer understand but probably not everyone else.
Refs #5462