-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add sphinx reference for whatsnew 3.3 #10564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like it worked https://pylint--10564.org.readthedocs.build/en/10564/whatsnew/3/3.3/index.html |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10564 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 176 176
Lines 19416 19416
=======================================
Hits 18619 18619
Misses 797 797 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I envision a pre-commit check where we check "words with dashes" against the message store and a pyenchant dict and then check that :ref:
is present.
Sounds good to me but might be tricky to implement. At least there are some edge cases which will need to be considered. Feel free to work on it if you're interested. I'll need to get back to the match performance improvements. Spend way to much time on this one today 😅 Do we want to merge this PR as is as a POC? And if so, should we backport it. If not, I can go ahead and close it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure !
(cherry picked from commit aa5adbf)
Description
Let's see if it works.
Refs #10563