-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[too-many-positional-arguments] Better documentation following questions #10049
[too-many-positional-arguments] Better documentation following questions #10049
Conversation
See https://github.com/astral-sh/ruff/issues/8946\#issuecomment-2437547742 Co-authored-by: Philipp Albrecht <flying-sheep@web.de>
@flying-sheep I credited you as co-author in the commit if you don't mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Left some minor suggestions.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Thank you ! Minor suggestions, major improvement π I tried to reuse the ``----- Keyword```from the python doc, then black destroyed everything by autoformatting, then I forgot to document in proper English π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps for another day - but currently we raise this message for positional-or-keyword arguments which is potentially problematic since we don't know if the function will be called with keywords or not.
I guess I don't see that as a problem. I think the point of this message is that since you don't know whether it will be called with keywords or not, you should force extra arguments to be called by keyword. |
Type of Changes
Description
Add clearer explanation for those who don't know about special parameters, cleanup remnant of the time the check was not implemented in pylint and only reserved the msgid/symbol to mirror ruff.
See https://github.com/astral-sh/ruff/issues/8946\#issuecomment-2437547742