Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/3.3.x] Bump astroid ceiling #10007

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024

Backport 7dc636b from #10006.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.3.2 milestone Oct 7, 2024
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the backport-10006-to-maintenance/3.3.x branch from 46f27a8 to f9a0b29 Compare October 7, 2024 13:23
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the backport, but I'm not sure we want to backport this. We won't have the possibility to do breaking changes in astroid without also leaking pylint's 4.x changes in our pylint's 3.x maintenance branch ?

@Pierre-Sassoulas Pierre-Sassoulas dismissed their stale review October 7, 2024 13:25

Only a comment not a change request

@jacobtylerwalls
Copy link
Member

Good point, I guess this is only here for allowing editable installs, usually the editable install would be run with main checked out, so I'm fine to close.

@Pierre-Sassoulas
Copy link
Member

It means we're possibly going to need to dust up the astroid 3.x maintenance branch but I guess it's better than having astroid 4.X fix in the pylint maintenance branch, what do you think ?

@jacobtylerwalls
Copy link
Member

SGTM, let's close

@jacobtylerwalls jacobtylerwalls deleted the backport-10006-to-maintenance/3.3.x branch October 7, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants