Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify no-else-raise and no-else-return also apply to try/except #10002

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Clarify no-else-raise and no-else-return also apply to try/except #10002

merged 3 commits into from
Oct 4, 2024
+10 −8

Conversation

levon-d
Copy link
Contributor

@levon-d levon-d commented Oct 3, 2024

Type
✓ 📜 Docs

Description

Clarify no-else-raise and no-else-return also apply to try/except

Closes #9901

Pierre-Sassoulas
Pierre-Sassoulas requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue. This part is generated from the code, you should modify the code in the checker directly then regenerate the doc :)

doc/user_guide/checkers/features.rst Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Skip news 🔇 This change does not require a changelog entry labels Oct 3, 2024
@levon-d
Copy link
Contributor Author

levon-d commented Oct 3, 2024

Thank you for working on this issue. This part is generated from the code, you should modify the code in the checker directly then regenerate the doc :)

Ahh, of course. Thank you for the review, will iterate :)

@levon-d levon-d force-pushed the docs/no-else-raise-no-else-return-fix branch from b916f40 to 2881c47 Compare October 3, 2024 19:42
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulation on becoming a pylint contributor 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4d3ad96 into pylint-dev:main Oct 4, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Documentation 📗 Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify no-else-raise and no-else-return also apply to try/except
2 participants
@levon-d @Pierre-Sassoulas