Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11-dev to Github actions #5920

Closed
Pierre-Sassoulas opened this issue Mar 15, 2022 · 12 comments · Fixed by #6551
Closed

Add Python 3.11-dev to Github actions #5920

Pierre-Sassoulas opened this issue Mar 15, 2022 · 12 comments · Fixed by #6551
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.11

Comments

@Pierre-Sassoulas
Copy link
Member

Current problem

Seems like tomllib has been accepted and merged python/cpython#31498 but not yet released to any of the images available on Github.

Next release is expected on 2022-04-05 so we'll need to wait a bit.

Desired solution

Add 3.11-dev when github actions are up to date and released.

Additional context

#5919 (comment)

@Pierre-Sassoulas Pierre-Sassoulas added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 15, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Mar 15, 2022
@HacKanCuBa

This comment was marked as resolved.

@Pierre-Sassoulas Pierre-Sassoulas modified the milestones: 2.14.0, 2.15.0 Apr 15, 2022
@cdce8p
Copy link
Member

cdce8p commented Apr 15, 2022

@HacKanCuBa This doesn't look like a pylint / astroid issue. I've I had to guess, maybe take a look at pydantic_factories?

Besides, I was able to set a Python 3.11.0a7 environment and run both pylint and pytest. We just have a lot a failing tests at the moment. IMO it doesn't really make sense to fix them atm, probably best to wait for the first beta release next month.

@HacKanCuBa
Copy link

HacKanCuBa commented Apr 15, 2022

Oh my, I posted it in the wrong project xD
Yes, it is indeed a Pydantic issue, sorry :P I was a bit sleepy, I miss-typed :P

Pierre-Sassoulas added a commit that referenced this issue May 8, 2022
Pierre-Sassoulas added a commit that referenced this issue May 8, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label May 8, 2022
@ssbarnea
Copy link
Contributor

ssbarnea commented Jun 1, 2022

To be honest I do think that it would highly desirable to enable py311 pipeline. It already in beta, I can easily make a PR if that is ok.

@DanielNoord
Copy link
Collaborator

@ssbarnea Agreed! However, we can't until we release a new version of astroid.

We're almost done with the release of pylint 2.14 which will probably be the last version without support for 3.11.
After that, I (and probably other maintainers) will focus on getting astroid 2.12 releasable, which includes support for 3.11.

@ssbarnea
Copy link
Contributor

ssbarnea commented Jun 1, 2022

I just discovered something that looks like serious problem E0611: No name 'path' in module 'os' (no-name-in-module)... when obviously os.path did not disappear.

@DanielNoord
Copy link
Collaborator

I just discovered something that looks like serious problem E0611: No name 'path' in module 'os' (no-name-in-module)... when obviously os.path did not disappear.

Is this with astroid on main? Or only with 2.12?

@ssbarnea
Copy link
Contributor

ssbarnea commented Jun 1, 2022

Apparently this happens only with astroid stable (2.11.5) but when installed from its main branch pylint worked. Maybe it worth making a 2.12 prerelease of it and use that as conditional dependency when python is 3.11 ? It might be an easy way to slowly enable 3.11 compatibility.

@DanielNoord
Copy link
Collaborator

Apparently this happens only with astroid stable (2.11.5) but when installed from its main branch pylint worked. Maybe it worth making a 2.12 prerelease of it and use that as conditional dependency when python is 3.11 ? It might be an easy way to slowly enable 3.11 compatibility.

I think we're nearing the release of 2.12 anyway. There are no real blockers in terms of PRs, just a number of PRs we/I would like to get in but haven't gotten around to reviewing. The issue with astroid is that most of the current maintainers of pylint are not as experienced with the internals of astroid so reviewing PRs and iterating on them takes considerably longer.
We're getting more and more experienced, but it takes some time.

@jacobtylerwalls
Copy link
Member

@ssbarnea thanks for testing! Do you have a reproducer for the issue with os.path? If so, could you open an issue on the astroid repository?

but when installed from its main branch pylint worked.

Installing pylint will pin astroid to a specific version, not stable. You can install astroid stable after installing pylint to make sure you are testing with astroid main branch.

@ssbarnea
Copy link
Contributor

ssbarnea commented Jun 2, 2022

Using astroid from master made pylint work, so I will wait for astroid to be released. If the issue does not happen on astroid@master, I doubt there is a good reason to file a bug with astroid.

@jacobtylerwalls
Copy link
Member

Apparently this happens only with astroid stable (2.11.5) but when installed from its main branch pylint worked.

Sorry, I misunderstood your post. I thought you meant pylint's main branch. Thanks for clarifying. 👍🏻

Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Jun 18, 2022
Pierre-Sassoulas added a commit that referenced this issue Jun 18, 2022
Pierre-Sassoulas added a commit that referenced this issue Jun 22, 2022
Pierre-Sassoulas added a commit that referenced this issue Jun 29, 2022
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Jul 9, 2022
cooperlees pushed a commit to facebookincubator/ptr that referenced this issue Jul 12, 2022
- Manually install deps for CI run in action
- Stop running pylint for now so we can pass in 3.11: pylint-dev/pylint#5920
- Remove config from .pylint that pylint said to do
- Fix tests to pass
cooperlees added a commit to facebookincubator/ptr that referenced this issue Jul 12, 2022
* Make CI pass for 3.11
- Manually install deps for CI run in action
- Stop running pylint for now so we can pass in 3.11: pylint-dev/pylint#5920
- Remove config from .pylint that pylint said to do
- Fix tests to pass

* Tell mypy to ignore unused type comments + make 3.11 CI fail now

* Add we support 3.11

Co-authored-by: Cooper Ry Lees <me@wcooperlees.com>
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Jul 21, 2022
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Jul 30, 2022
Pierre-Sassoulas added a commit that referenced this issue Aug 21, 2022
@DanielNoord DanielNoord modified the milestones: 2.15.0, 2.15.1 Aug 23, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.15.1 milestone Sep 1, 2022
Pierre-Sassoulas added a commit that referenced this issue Sep 19, 2022
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this issue Sep 24, 2022
Closes pylint-dev#5920

Take comment from hugovk into account
Pierre-Sassoulas added a commit that referenced this issue Sep 24, 2022
Closes #5920

Take comment from hugovk into account
Pierre-Sassoulas added a commit that referenced this issue Sep 30, 2022
Use ``dill-pylint`` (our own version of dill) because dill's 0.3.6 release is taking forever.

Closes #5920

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
orSolocate pushed a commit to orSolocate/pylint that referenced this issue Oct 1, 2022
Use ``dill-pylint`` (our own version of dill) because dill's 0.3.6 release is taking forever.

Closes pylint-dev#5920

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.11
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants