Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit test dependency on yanked package #10117

Closed
jacobtylerwalls opened this issue Dec 8, 2024 · 3 comments · Fixed by #10119
Closed

Remove explicit test dependency on yanked package #10117

jacobtylerwalls opened this issue Dec 8, 2024 · 3 comments · Fixed by #10119
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow

Comments

@jacobtylerwalls
Copy link
Member

see logs in "Create python virtual environment" step

WARNING: The candidate selected for download or install is a yanked version: 'types-pkg-resources' candidate (version 0.1.3 at https://files.pythonhosted.org/packages/e9/97/a24ffd614ac2962dabbd599afbed00adf6464604a53b96b5f48301518a5f/types_pkg_resources-0.1.3-py2.py3-none-any.whl (from https://pypi.org/simple/types-pkg-resources/))
Reason for being yanked: Use types-setuptools instead
@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Dec 8, 2024
@Pierre-Sassoulas
Copy link
Member

Nice catch!

@Pierre-Sassoulas
Copy link
Member

It seems like it's due to a transitive dependency, I can't find the string anywhere in the codebase;

grep -rH "types-pkg-resources" .:

./tests/.pylint_primer_tests/home-assistant/core/requirements_test.txt:types-pkg-resources==0.1.3

git grep -rH "types-pkg-resources" .: nothing.

@jacobtylerwalls
Copy link
Member Author

try types-pkg_resources with underscore

Pierre-Sassoulas added a commit that referenced this issue Dec 8, 2024
@Pierre-Sassoulas
[mypy] Use type-setuptools instead of types-pkg-resources
882c3db 
Closes #10117
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Dec 8, 2024
Merged
jacobtylerwalls pushed a commit that referenced this issue Dec 8, 2024
@Pierre-Sassoulas @jacobtylerwalls
[mypy] Use type-setuptools instead of types-pkg-resources
fa00126 
Closes #10117
github-actions bot pushed a commit that referenced this issue Dec 8, 2024
@Pierre-Sassoulas @github-actions
[mypy] Use type-setuptools instead of types-pkg-resources
e8160b1 
Closes #10117

(cherry picked from commit fa00126)
jacobtylerwalls pushed a commit that referenced this issue Dec 8, 2024
@github-actions @Pierre-Sassoulas
[mypy] Use type-setuptools instead of types-pkg-resources (#10120)
90cb29d 
Closes #10117

(cherry picked from commit fa00126)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mypy] Use type-setuptools instead of types-pkg-resources pylint-dev/pylint
2 participants
@Pierre-Sassoulas @jacobtylerwalls