Add typing and remove TODO

pylint-dev · Nov 16, 2021 · 9db3e0f · 9db3e0f
1 parent 99cd3a9
commit 9db3e0f
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 7 deletions.
diff --git a/.pylint_primer_tests/django/django b/.pylint_primer_tests/django/django
diff --git a/.pylint_primer_tests/getsentry/sentry b/.pylint_primer_tests/getsentry/sentry
diff --git a/.pylint_primer_tests/home-assistant/core b/.pylint_primer_tests/home-assistant/core
diff --git a/.pylint_primer_tests/keras-team/keras b/.pylint_primer_tests/keras-team/keras
diff --git a/.pylint_primer_tests/pallets/flask b/.pylint_primer_tests/pallets/flask
diff --git a/.pylint_primer_tests/pandas-dev/pandas b/.pylint_primer_tests/pandas-dev/pandas
diff --git a/.pylint_primer_tests/psf/black b/.pylint_primer_tests/psf/black
diff --git a/.pylint_primer_tests/pygame/pygame b/.pylint_primer_tests/pygame/pygame
diff --git a/.pylint_primer_tests/scikit-learn/scikit-learn b/.pylint_primer_tests/scikit-learn/scikit-learn
diff --git a/.pylint_primer_tests/vimeo/graph-explorer b/.pylint_primer_tests/vimeo/graph-explorer
diff --git a/pylint/checkers/variables.py b/pylint/checkers/variables.py
@@ -1392,8 +1392,8 @@ def _in_lambda_or_comprehension_body(
     def _is_variable_violation(
         node: nodes.Name,
         defnode,
-        stmt,
-        defstmt,
+        stmt: nodes.Statement,
+        defstmt: nodes.Statement,
         frame,  # scope of statement of node
         defframe,
         base_scope_type,
@@ -1580,12 +1580,8 @@ def _is_variable_violation(
 
         return maybee0601, annotation_return, use_outer_definition
 
-    # pylint: disable-next=fixme
-    # TODO: The typing of `NodeNG.statement()` in astroid is non-specific
-    # After this has been updated the typing of `defstmt` should reflect this
-    # See: https://github.com/PyCQA/astroid/pull/1217
     @staticmethod
-    def _is_only_type_assignment(node: nodes.Name, defstmt: nodes.NodeNG) -> bool:
+    def _is_only_type_assignment(node: nodes.Name, defstmt: nodes.Statement) -> bool:
         """Check if variable only gets assigned a type and never a value"""
         if not isinstance(defstmt, nodes.AnnAssign) or defstmt.value:
             return False