Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 666 pure #739

Merged
merged 5 commits into from
Jan 5, 2020
Merged

Bug 666 pure #739

merged 5 commits into from
Jan 5, 2020

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Dec 28, 2019

Steps

  • [ * ] For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • [ * ] Write a good description on what the PR does.

Description

This PR solves the issue #666.
The problem was that astroid could not infer the result of a call to append function because this function, itself, calls the concatenate function.
This last function is inferred thanks to the brain_numpy_core_multiarray module but only when the corresponding node is an astroid.Attribute (for example numpy.concatenate). It turns out that in the source of the append function the node that realises the call to concatenate is a astroid.Name. Thus the correction proposed here is to register the concatenate inference tip function in order to apply it, also, to astroid.Name.

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes #666

@PCManticore PCManticore merged commit 59f0be7 into master Jan 5, 2020
@PCManticore PCManticore deleted the bug_666_pure branch January 5, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add numpy brain tips for numpy.append
2 participants