make is_standard_module() properly classify extensions #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmcclain
changed the title
Extensions can be installed in either a platform independent or specific location[1]. The search is updated to include both paths. Previously, an extension in the platform specific location would be misclassified because only the independent location was considered and the platform specific location shared a prefix with the standard lib. [1] http://docs.python.org/3/distutils/apiref.html#distutils.sysconfig.get_python_lib Fixes Issue: pylint-dev#658 Co-authored-by: Matt Story <s.matt.story@gmail.com>
markmcclain
force-pushed
the
fix_extension_classification
branch
from
d6db368
to
2f336eb
Compare
|
Thank you for the great patch @markmcclain ! |
markmcclain
added a commit
to markmcclain/astroid
that referenced
this pull request
Apr 4, 2019
Extensions can be installed in either a platform independent or specific location[1]. The search is updated to include both paths. Previously, an extension in the platform specific location would be misclassified because only the independent location was considered and the platform specific location shared a prefix with the standard lib. [1] http://docs.python.org/3/distutils/apiref.html#distutils.sysconfig.get_python_lib Fixes Issue: pylint-dev#658 Co-authored-by: Matt Story <s.matt.story@gmail.com> (cherry picked from commit 70ed2cf)
PCManticore
pushed a commit
that referenced
this pull request
Apr 9, 2019
Extensions can be installed in either a platform independent or specific location[1]. The search is updated to include both paths. Previously, an extension in the platform specific location would be misclassified because only the independent location was considered and the platform specific location shared a prefix with the standard lib. [1] http://docs.python.org/3/distutils/apiref.html#distutils.sysconfig.get_python_lib Fixes Issue: #658 Co-authored-by: Matt Story <s.matt.story@gmail.com> (cherry picked from commit 70ed2cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions can be installed in either a platform independent or specific
location[1]. The search is updated to include both paths. Previously, an
extension in the platform specific location would be misclassified because
only the independent location was considered and the platform specific location
shared a prefix with the standard lib.
[1] http://docs.python.org/3/distutils/apiref.html#distutils.sysconfig.get_python_lib
Close: #658
Co-authored-by: Matt Story s.matt.story@gmail.com
Steps
Description
Type of Changes
Related Issue
Closes #658