Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with manager.clear_cache() not fully clearing the cache #2572

Merged
merged 8 commits into from
Sep 22, 2024

Conversation

akamat10
Copy link
Contributor

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Refs pylint-dev/pylint#9932 (comment)

@jacobtylerwalls jacobtylerwalls added this to the 3.3.4 milestone Sep 21, 2024
ChangeLog Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.06%. Comparing base (1368be1) to head (ba5c1a1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          93       93           
  Lines       11063    11064    +1     
=======================================
+ Hits        10296    10297    +1     
  Misses        767      767           
Flag Coverage Ξ”
linux 92.95% <100.00%> (+<0.01%) ⬆️
pypy 93.06% <100.00%> (+<0.01%) ⬆️
windows 93.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/manager.py 90.00% <100.00%> (+0.04%) ⬆️

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great detective work, and the clean test case is much appreciated!

tests/test_manager.py Outdated Show resolved Hide resolved
@jacobtylerwalls jacobtylerwalls merged commit 58286a1 into pylint-dev:main Sep 22, 2024
20 checks passed
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2572-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58286a1bbe55f41dc2eca0ae61755d030654f093
# Push it to GitHub
git push --set-upstream origin backport-2572-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2572-to-maintenance/3.3.x.

jacobtylerwalls pushed a commit that referenced this pull request Sep 22, 2024
jacobtylerwalls pushed a commit that referenced this pull request Sep 22, 2024
jacobtylerwalls added a commit that referenced this pull request Sep 22, 2024
… (#2573)

(cherry picked from commit 58286a1)

Co-authored-by: Akhil Kamat <akhil.kamat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants