Infer user-defined enum classes by checking if the class is a subtype of enum.Enum

[mbyrnepr2]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
	📜 Docs

Description

Infer user-defined enum classes by checking if the class is a subtype of enum.Enum.

Closes pylint-dev/pylint#8897

[mbyrnepr2]

cls.mro() wasn't returning the enum ancestors in the case of the example on the original issue; hence the class never made became inferred. (it only returned a single-item list containing the original class itself).

[jacobtylerwalls]

Looks like a slight performance improvement, too, based on the small sample size of profiling astroid.

[Pierre-Sassoulas]

On top of the fix, it seems like a more sensible approach indeed, good job. Did we have tests for each hard coded subclasses from the removed constants ? (I want to make sure that intEnum are still handled correctly)

[mbyrnepr2]

On top of the fix, it seems like a more sensible approach indeed, good job. Did we have tests for each hard coded subclasses from the removed constants ? (I want to make sure that intEnum are still handled correctly)

Yes for IntEnum.
No for IntFlag - there's tests for it in Pylint but makes sense to have one here in astroid with the others.

[jacobtylerwalls]

Sorry if this test will be difficult to rewrite! Maybe an extra inference call in the setup?

[mbyrnepr2]

@jacobtylerwalls I've tried a few things to modify the test but no luck; when the program enters the enum brain module and into the is_subtype_of function we are getting a StopIteration (if I recall correctly) and the context path doesn't behave as expected. I've also had little time lately 😬.

[codecov]

Codecov Report

Merging #2277 (0dd9498) into main (ea78827) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   92.85%   92.85%   -0.01%     
==========================================
  Files          94       94              
  Lines       11058    11054       -4     
==========================================
- Hits        10268    10264       -4     
  Misses        790      790              

Flag	Coverage Δ
linux	92.66% <100.00%> (-0.01%)	⬇️
pypy	90.99% <100.00%> (-0.02%)	⬇️
windows	92.44% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
astroid/brain/brain_namedtuple_enum.py	92.88% <100.00%> (-0.10%)	⬇️