Prefer stdlib modules over same-named modules on sys.path #2223
+36
β2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
Bug πͺ³
pylint-tested
jacobtylerwalls
commented
Jun 23, 2023
jacobtylerwalls
force-pushed
the
same-name-stdlib
branch
5 times, most recently
from
02f375b
to
7a6b60f
Compare
For example: `import copy` now finds `copy` instead of `copy.py`. This worked correctly before in at least some cases if there was a (more?) complete chain of __init__.py files from cwd all the way to the location of the `copy.py` module. Closes pylint-dev/pylint#6535
jacobtylerwalls
force-pushed
the
same-name-stdlib
branch
from
cb0007c
to
b8755ba
Compare
jacobtylerwalls
force-pushed
the
same-name-stdlib
branch
from
e0d3f36
to
dae5921
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 94 94
Lines 11053 11055 +2
=======================================
+ Hits 10263 10265 +2
Misses 790 790
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Pierre-Sassoulas
previously approved these changes
Jun 27, 2023
DanielNoord
reviewed
Jun 27, 2023
| @@ -157,6 +157,19 @@ def find_module( | |||
| location=getattr(spec.loader_state, "filename", None), | |||
| type=ModuleType.PY_FROZEN, | |||
| ) | |||
| if ( | |||
There was a problem hiding this comment.
Could this clash with namespace modules?
There was a problem hiding this comment.
Could you flesh this out a little more for me? (Sorry!)
There was a problem hiding this comment.
β― tree .
.
βββ argparse.py
βββ test.py
1 directory, 2 files# test.py
import argparse
argparse.i_dont_exist()# argparse.py
def i_dont_exist():
print("1")β― python test.py
1Won't this implementation default to stdlib.argparse instead of the local argparse?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Oops, in the comment I just hid I hadn't run the test case against the correct copy of astroid. More soon.
jacobtylerwalls
removed
the
pylint-tested
jacobtylerwalls
added
the
Needs take over ποΈ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Prefer stdlib modules over same-named modules on sys.path
For example:
import copynow findscopyinstead ofcopy.py.This worked correctly before in at least some cases if there was a (more?) complete chain of
__init__.pyfiles from cwd all the way to the location of thecopy.pymodule.Closes pylint-dev/pylint#6535