Refactor: Stop adding arbitrary attributes to module obj when building

[thejcannon]

Steps

• For new features or bug fixes, add a ChangeLog entry describing what your PR does.
• Write a good description on what the PR does.

Description

Moving code from _post_build into _data_build so that we don't have to attach arbitrary objects to the module (namely _import_from_nodes, and _delayed_assattr).

Alternatively we could:

• Keep the code in _post_build and pass the info along
• Same, but pass the builder

Type of Changes

	Type
	🐛 Bug fix
	✨ New feature
✓	🔨 Refactoring
	📜 Docs

Related Issue

[DanielNoord]

Based on the tests and the actual code I this change seems fine? It doesn't actually do much different, other than making the code more readable since _post_build is called after _data_build anyway.

Edit: And by the way @thejcannon sorry for letting this PR drop down into "stale-PR-hell" 😅

[DanielNoord]

Shouldn't the cache_module stay in _post_build? If we ever do something different in _data_build after this line or we add a method between _data_build and _post_build it won't be cached?

[cdce8p]

I think it wouldn't matter. The module object reference is cached, ie. if the object changes, those changes are also reflected in the cache.

[cdce8p]

I would prefer if we kept the logic inside _post_build. IMO passing the builder along is probably the better alternative.

Updated code

[cdce8p]

I've updated the code to pass builder along instead. Didn't want to drag this on any longer.

[Pierre-Sassoulas]

LGTM thank you @thejcannon and @cdce8p