Fix yield inference on inherited classes. #1092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pierre-Sassoulas
added
the
pylint-tested
Pierre-Sassoulas
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
LGTM. I tested it in pylint and there's no regression. I does not fix #1008, which probably means it was not a duplicate even if it looks similar.
|
Thank you again for thinking about and fixing this circular import issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Description
This fixes issue #1090. I'm not sure if this is the right way to fix it, the old problem was that the yield values were inferred in a later context. Because a generator in Python stores a specific context, I thought that it should also be reflected in
astroid's code. I'd be glad to get feedback.Thanks!
Type of Changes
Related Issue
If this PR fixes a particular issue, use the following to automatically close that issue
once this PR gets merged:
Closes #1090