Define dependencies in submission script #299
Conversation
|
Warning Rate Limit Exceeded@jan-janssen has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 56 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent changes enhance the job submission functionality in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- pysqa/ext/modular.py (1 hunks)
- pysqa/utils/basic.py (8 hunks)
- tests/config/flux/flux.sh (1 hunks)
- tests/config/slurm/slurm.sh (1 hunks)
Additional Context Used
ShellCheck (40)
tests/config/flux/flux.sh (20)
[error] 7-7: You need a space after the '{'.
[warning] 7-7: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 9-9: You need a space after the '{'.
[warning] 9-9: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 10-10: You need a space after the '{'.
[warning] 10-10: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 11-11: You need a space after the '{'.
[warning] 11-11: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 13-13: You need a space after the '{'.
[warning] 13-13: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 14-14: You need a space after the '{'.
[warning] 14-14: This } is literal. Check expression (missing ;/\n?) or quote it.
[info] 16-16: The mentioned syntax error was in this brace group.
[error] 16-16: You need a space after the '{'.
[error] 16-16: Couldn't parse this brace group. Fix to allow more checks.
[error] 16-16: You need a space after the '{'.
[warning] 16-16: This } is literal. Check expression (missing ;/\n?) or quote it.
[warning] 16-16: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 16-16: Expected a '}'. If you have one, try a ; or \n in front of it.
[error] 16-16: Missing '}'. Fix any mentioned problems and try again.
tests/config/slurm/slurm.sh (20)
[error] 7-7: You need a space after the '{'.
[warning] 7-7: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 9-9: You need a space after the '{'.
[warning] 9-9: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 10-10: You need a space after the '{'.
[warning] 10-10: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 12-12: You need a space after the '{'.
[warning] 12-12: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 13-13: You need a space after the '{'.
[warning] 13-13: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 15-15: You need a space after the '{'.
[warning] 15-15: This } is literal. Check expression (missing ;/\n?) or quote it.
[info] 18-18: The mentioned syntax error was in this brace group.
[error] 18-18: You need a space after the '{'.
[error] 18-18: Couldn't parse this brace group. Fix to allow more checks.
[error] 18-18: You need a space after the '{'.
[warning] 18-18: This } is literal. Check expression (missing ;/\n?) or quote it.
[warning] 18-18: This } is literal. Check expression (missing ;/\n?) or quote it.
[error] 19-19: Expected a '}'. If you have one, try a ; or \n in front of it.
[error] 19-19: Missing '}'. Fix any mentioned problems and try again.
Additional comments not posted (2)
pysqa/ext/modular.py (1)
66-73: The addition of thedependency_listparameter is correctly implemented.pysqa/utils/basic.py (1)
Line range hint
351-442: The addition of thedependency_listparameter is correctly implemented across multiple methods.
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- tests/test_gent.py (1 hunks)
- tests/test_lsf.py (1 hunks)
- tests/test_moab.py (1 hunks)
- tests/test_sge.py (1 hunks)
- tests/test_slurm.py (1 hunks)
- tests/test_torque.py (1 hunks)
Additional Context Used
Ruff (1)
tests/test_sge.py (1)
11-11:
defusedxml.ElementTreeimported but unused; consider usingimportlib.util.find_specto test for availability
Additional comments not posted (11)
tests/test_moab.py (2)
45-45: LGTM! Good addition of robustness test for incorrect arguments.
52-52: LGTM! Properly tests the command formation for Moab.tests/test_lsf.py (2)
56-56: LGTM! Properly tests the command formation for LSF.
61-61: LGTM! Good addition of robustness test for incorrect arguments in LSF.tests/test_torque.py (2)
44-44: LGTM! Properly tests the command formation for Torque.
49-49: LGTM! Good addition of robustness test for incorrect arguments in Torque.tests/test_sge.py (2)
113-113: LGTM! Properly tests the command formation for SGE.
118-118: LGTM! Good addition of robustness test for incorrect arguments in SGE.tests/test_gent.py (2)
59-59: LGTM! Properly tests the command formation for Gent.
64-64: LGTM! Good addition of robustness test for incorrect arguments in Gent.tests/test_slurm.py (1)
74-74: LGTM! Properly tests the command formation for Slurm.
Summary by CodeRabbit
New Features
Bug Fixes
Tests
fluxandslurm.These updates improve the accuracy and efficiency of job scheduling by enabling users to define dependencies between jobs.