hooks: torch: suppress generation of symlinks for shared libs #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `torch` test that tries to solve a system of linear equations using `torch.linalg` with input tensors stored on a CUDA device (provided one is available). This test shows that symbolic links created by binary dependency analysis for shared libraries in `torch/lib` to the top-level application directory confuse certain torch builds about the location of `torch`, and prevent `torch/lib/libtorch_cuda_linalg.so` from being (dynamically) loaded.
On Linux, have the `torch` hook use the`bindepend_symlink_suppression` hook attribute to prevent PyInstaller's binary dependency analysis from creating symlinks to top-level application directory for shared libraries discovered in the `torch/lib` directory during binary dependency analysis. These symbolic links confuse certain `torch` builds about the location of `torch`, and prevent `torch/lib/libtorch_cuda_linalg.so` from being (dynamically) loaded. The problematic builds are wheels provided by https://download.pytorch.org/whl/torch for `torch` 1.13.x, 2.0.x, and 2.1.x (tested with 1.13.1+cu117, 2.0.1+cu117, and 2.1.2+cu118). Later versions do not seem to be affected. The wheels provided on PyPI do not seem to be affected either, regardless of the version. However, these symlinks should be not necessary on linux in general, so there should be no harm in suppressing them for all versions.
bwoodsend
approved these changes
Dec 3, 2024
|
This works, thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, have the
torchhook use thebindepend_symlink_suppressionhook attribute to prevent PyInstaller's binary dependency analysis from creating symlinks to top-level application directory for shared libraries discovered in thetorch/libdirectory during binary dependency analysis.These symbolic links confuse certain
torchbuilds about the location oftorch, and preventtorch/lib/libtorch_cuda_linalg.sofrom being (dynamically) loaded. The problematic builds are wheels provided by https://download.pytorch.org/whl/torch fortorch1.13.x, 2.0.x, and 2.1.x (tested with 1.13.1+cu117, 2.0.1+cu117, and 2.1.2+cu118). Later versions do not seem to be affected. The wheels provided on PyPI do not seem to be affected either, regardless of the version.However, these symlinks should be not necessary on linux in general, so there should be no harm in suppressing them for all versions.
Fixes #834.