-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature IMDb #191
New feature IMDb #191
Conversation
|
Hey @ZoeyKats Can you add it to the README? Thanks! |
Sure i just did it! |
Hey there, thanks for the contribution! I see you opened another PR for the There's also a few issues with regards to formatting/style Can you please do the following:
|
I finished what you asked me to do, I hope everything is ok. Please tell me if there is something else I need to do |
I found out I messed up a little bit when I formatted the code. I just committed the correct one. Sorry for any trouble |
@Abdur-rahmaanJ and @MrTanoshii , there are something missing here? Or we already can merge it? |
@paulosgf we can merge! |
@ZoeyKats, I'm updating de documentation and then I found a bug complaining that the imdb module is missing. I'm trying to install it, but PyPI has no module named imdb. How I can import it?
|
@paulosgf you can try pip install cinemagoer , sorry for not mentioning it earlier i had totally forgotten about this issue. I think the package IMDbPY was renamed to cinemagoer that's the reason it changed. |
Can you update your plug-in with this module? Don't forget requirements.txt |
@ZoeyKats , did you see this message? |
@paulosgf hey sorry i just saw this, i'll make sure to change it! |
I have written the code for imdb feature, i hope you like it
README.md
Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct