-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the new plugin: basketball #187
Conversation
|
Great PR else! |
@MrTanoshii Please review |
hey @kefthymic Can you add it on the README? Thanks! |
Hello @Abdur-rahmaanJ . I added the plugin on the README. Is it ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few formatting/style issues with main.py
and README.md
Can you please do the following:
- Run the command
black main.py
- Format
README.md
using VS Code or a free tool like https://codebeautify.org/markdown-formatter
@MrTanoshii I formatted the README using the https://codebeautify.org/markdown-formatter as you told me and also ran the command for the main.py. Is there anything I need to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you once again! There's nothing else to do, your plugin is now merged 🥳 |
Description
I finished the basketball plugin. I tested my code using the test_plugin_script.