Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain switching #319

Merged
merged 7 commits into from
May 27, 2021
Merged

Domain switching #319

merged 7 commits into from
May 27, 2021

Conversation

fubarhouse
Copy link
Collaborator

This PR basically eliminates the need for hard-coded domains.
Would be handy in the event the domain needed to be changed - it's even configurable.

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@tobybellwood
Copy link
Collaborator

Can this support multiple domains? IE the default, but also an additional one?

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@fubarhouse
Copy link
Collaborator Author

fubarhouse commented May 26, 2021

Well, it would be possible to add a second resolver based upon input domains.
Would the idea be that you have an entire stack of pygmy containers for each domain?

Not entirely sure what that would look like, but the idea is that this makes that goal a little easier. It'll remove a blocker for that later down the line, if that is intended.

edit: I remember there is a PR for multiple domain support in haproxy - perhaps that model would be a good starting point. If that was configured then yes, it would require minimal work for pygmy to support.

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@fubarhouse
Copy link
Collaborator Author

@tobybellwood see here for example:
amazeeio/docker-haproxy#3

That would be freaking sweet actually and pygmy would do it, but it's not something I have influence over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants