Don't warn in present() #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korijn
previously approved these changes
Mar 22, 2024
|
You could also lower the logging level to debug. But anyway, I approve :) |
|
Lol, silly how I did not think of that. I think making it a debug message is much better. I also added some context in the message. |
Korijn
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning was intended to help people who forgot to call
get_current_texture(). But it looks like it does more harm then help, because when an exception happens in the draw function, the warning is printed below, making it easy to interpret that that is the error message. See e.g. pygfx/pygfx#682