Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FRect repr to handle larger values #3077

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Update FRect repr to handle larger values #3077

merged 1 commit into from
Aug 24, 2024

Conversation

ankith26
Copy link
Member

Before this PR

>>> pygame.FRect(-2e38, -2e38, -2e38, -2e38)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: Internal PyOS_snprintf call failed!

After this PR

>>> pygame.FRect(-2e38, -2e38, -2e38, -2e38)
FRect(-199999993605713849301312521538346418176.000000, -199999993605713849301312521538346418176.000000, -199999993605713849301312521538346418176.000000, -199999993605713849301312521538346418176.000000)

@ankith26 ankith26 requested a review from a team as a code owner August 22, 2024 08:02
@ankith26 ankith26 changed the title Update Frect repr to handle larger values Update FRect repr to handle larger values Aug 22, 2024
@ankith26 ankith26 force-pushed the ankith26-frect-repr-fix branch from bd5e7f7 to 0916bf6 Compare August 22, 2024 08:08
@damusss damusss added rect pygame.rect bugfix PR that fixes bug labels Aug 22, 2024
damusss
damusss approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 👍

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 22, 2024
Starbuck5
Starbuck5 approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol that's a funny bug.

How'd you run into it? Or did someone report it?

Solution looks good.

@ankith26
Copy link
Member Author

It was reported on discord, by maya. While at it, they also reported issues that lead to me making #3078

@ankith26 ankith26 merged commit ae066f8 into main Aug 24, 2024
26 checks passed
@ankith26 ankith26 deleted the ankith26-frect-repr-fix branch August 24, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damusss damusss damusss approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug rect pygame.rect
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ankith26 @Starbuck5 @damusss