Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ga.ReciprocalFrame #308

Merged
merged 1 commit into from
May 6, 2020

Conversation

eric-wieser
Copy link
Member

Also deprecates passing mode="nonsense", and improves the docstring.

Split from #249

@eric-wieser eric-wieser added component: docs Documentation Deprecation Precursor to removal of features labels May 6, 2020
Also deprecates passing `mode="nonsense"`, and improves the docstring.
@eric-wieser eric-wieser force-pushed the add-ReciprocalFrame-test branch from 5c76839 to f47cafd Compare May 6, 2020 10:02
@eric-wieser eric-wieser requested a review from utensil May 6, 2020 10:13
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #308 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   72.62%   72.65%   +0.03%     
==========================================
  Files          15       15              
  Lines        4398     4400       +2     
==========================================
+ Hits         3194     3197       +3     
+ Misses       1204     1203       -1     
Impacted Files Coverage Δ
galgebra/ga.py 77.10% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 252d5f3...f47cafd. Read the comment docs.

@utensil utensil merged commit 3ab7892 into pygae:master May 6, 2020
@eric-wieser eric-wieser deleted the add-ReciprocalFrame-test branch May 12, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: docs Documentation Deprecation Precursor to removal of features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants