Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid passing coefficients to odd Mvs #180

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Conversation

eric-wieser
Copy link
Member

Closes gh-81.

This makes this consistent with the even and mv constructors.

Closes pygaegh-81.

This makes this consistent with the `even` and `mv` constructors.
@eric-wieser eric-wieser added this to the 0.4.5 milestone Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #180 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   67.84%   67.84%   -0.01%     
==========================================
  Files           9        9              
  Lines        4684     4686       +2     
==========================================
+ Hits         3178     3179       +1     
- Misses       1506     1507       +1
Impacted Files Coverage Δ
galgebra/mv.py 64.63% <50%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce4920...4e902f3. Read the comment docs.

@eric-wieser eric-wieser added the ✓ soft CI failure PRs which fail quality but not test CIs label Dec 18, 2019
@utensil utensil merged commit d4fe3db into pygae:master Dec 18, 2019
@eric-wieser eric-wieser deleted the fix-81 branch December 18, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ✓ soft CI failure PRs which fail quality but not test CIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mv(coeffs, 'odd') is nonsensical
2 participants