Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yet more special-casing of the hestenes dot product #154

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 16, 2019

Continues from #134 and 6cc530c

This also changes some sympy zeros to multivector zeros, which means that (A | scalar) ^ (B | scalar) is not a TypeError, as it was before:

>>> s = g.mv(1, 'scalar')
>>> (ex | s) ^ (ey | s)
TypeError: unsupported operand type(s) for ^: 'Zero' and 'Zero'

This also changes some sympy zeros to multivector zeros, which means that `(A | scalar) ^ (B | scalar)` is not a TypeError
@eric-wieser eric-wieser force-pushed the more-hestenes-special-casing branch from 18fd09e to 09147b1 Compare December 16, 2019 17:59
@eric-wieser eric-wieser requested a review from utensil December 16, 2019 18:05
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #154 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   67.14%   67.12%   -0.03%     
==========================================
  Files           8        8              
  Lines        4761     4758       -3     
==========================================
- Hits         3197     3194       -3     
  Misses       1564     1564
Impacted Files Coverage Δ
galgebra/mv.py 62.8% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a947dd1...09147b1. Read the comment docs.

Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@utensil utensil merged commit a797cf4 into pygae:master Dec 16, 2019
@eric-wieser eric-wieser deleted the more-hestenes-special-casing branch December 17, 2019 10:35
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants