numba: fix overload_call on numba >= 0.54.0 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
fix-numba-0.54.0
branch
from
4f50767 to
13ac052
Compare
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 71.35% 71.37% +0.01%
==========================================
Files 73 73
Lines 9454 9459 +5
Branches 1211 1211
==========================================
+ Hits 6746 6751 +5
Misses 2538 2538
Partials 170 170
Continue to review full report at Codecov.
|
|
CI has gone from red to green, so let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref numba/numba#7061.
We were burnt by relying on implementation details, but as numba/numba#5886 never quite worked we had no choice.