Raise error if len(DynamicBatchSampler()) is ambiguous
#8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8137 +/- ##
==========================================
- Coverage 88.84% 88.14% -0.70%
==========================================
Files 471 471
Lines 28278 28275 -3
==========================================
- Hits 25123 24923 -200
- Misses 3155 3352 +197
... and 34 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
akihironitta
requested review from
wsad1,
mananshah99 and
a team
as code owners
akihironitta
changed the title
DynamicBatchSampler.__len__len(DynamicBatchSampler()) is ambiguous
rusty1s
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a fix for #7724.
Assuming
len(DynamicBatchSampler(dataset)) == len(dataset)is wrong in AFAIK all casesmax_num>1, which can lead to undesired behaviour in 3rd party libraries like PyTorch Lightning as reported in the linked issue.