Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Coverage] data/data.py & data/hetero_data.py & nn/conv/eg_conv.py #8047

Merged
merged 7 commits into from
Sep 24, 2023
Merged

[Code Coverage] data/data.py & data/hetero_data.py & nn/conv/eg_conv.py #8047

merged 7 commits into from
Sep 24, 2023

Conversation

xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Sep 17, 2023

Not sure if I am misunderstanding, please take a look:)

@codecov
Copy link

codecov bot commented Sep 17, 2023 •
edited
Loading

Codecov Report

Merging #8047 (a8fb979) into master (99f7047) will decrease coverage by 0.55%.
The diff coverage is 100.00%.

❗ Current head a8fb979 differs from pull request most recent head d8f3334. Consider uploading reports for the commit d8f3334 to get more accurate results

@@            Coverage Diff             @@
##           master    #8047      +/-   ##
==========================================
- Coverage   89.27%   88.72%   -0.55%     
==========================================
  Files         467      467              
  Lines       27879    27878       -1     
==========================================
- Hits        24889    24735     -154     
- Misses       2990     3143     +153
Files Changed Coverage Δ
torch_geometric/data/data.py 92.80% <100.00%> (+4.47%) ⬆️
torch_geometric/data/hetero_data.py 91.07% <100.00%> (+3.03%) ⬆️
torch_geometric/nn/conv/eg_conv.py 87.50% <100.00%> (+2.02%) ⬆️

... and 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s enabled auto-merge (squash) September 24, 2023 14:33
@rusty1s rusty1s merged commit 4a0272e into pyg-team:master Sep 24, 2023
JakubPietrakIntel pushed a commit that referenced this pull request Sep 27, 2023
@xnuohz @rusty1s @JakubPietrakIntel
[Code Coverage] data/data.py & data/hetero_data.py & `nn/conv/eg_…
f8c2241 
…conv.py` (#8047)

- Part of #6528
- Fix `AttributeError: 'function' object has no attribute 'pop'` when
calling `remove_edge_index`

Not sure if I am misunderstanding, please take a look:)

---------

Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
@xnuohz xnuohz deleted the code-coverage-data branch October 17, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@mananshah99 mananshah99 Awaiting requested review from mananshah99 mananshah99 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@xnuohz xnuohz

Labels
0 - Priority P0 data nn skip-changelog test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xnuohz @rusty1s