Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding capabilities to HeteroData.to_homogeneous() #7374

Merged
merged 12 commits into from
May 17, 2023

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented May 16, 2023

useful for putting randomly generated FakeHeteroDataset data into a fused GNN like RGCNConv, otherwise the fakeheterodataset usually has x's w/ diff num of features and the resulting Data would not have any node features w/o this PR

@puririshi98 puririshi98 requested a review from rusty1s May 16, 2023 17:40
@puririshi98 puririshi98 self-assigned this May 16, 2023
@puririshi98 puririshi98 requested a review from mananshah99 as a code owner May 16, 2023 17:40
@github-actions github-actions bot added the data label May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #7374 (2964260) into master (2e64b0f) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

❗ Current head 2964260 differs from pull request most recent head 979be58. Consider uploading reports for the commit 979be58 to get more accurate results

@@            Coverage Diff             @@
##           master    #7374      +/-   ##
==========================================
- Coverage   91.31%   91.30%   -0.01%     
==========================================
  Files         439      439              
  Lines       24494    24510      +16     
==========================================
+ Hits        22366    22379      +13     
- Misses       2128     2131       +3     
Impacted Files Coverage Δ
torch_geometric/data/hetero_data.py 90.89% <82.35%> (-0.32%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@puririshi98 puririshi98 changed the title to_homo padding to_homogeneous padding May 16, 2023
@rusty1s rusty1s requested a review from wsad1 as a code owner May 17, 2023 21:50
@rusty1s rusty1s changed the title to_homogeneous padding Add padding capabilities to HeteroData.to_homogeneous() May 17, 2023
@rusty1s rusty1s enabled auto-merge (squash) May 17, 2023 22:00
@rusty1s rusty1s merged commit ce84dd9 into master May 17, 2023
@rusty1s rusty1s deleted the to_homogeneous_pad branch May 17, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants