-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing HGTConv
with FastHGTConv
#7117
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 91.30% 91.27% -0.03%
==========================================
Files 437 436 -1
Lines 24002 23913 -89
==========================================
- Hits 21915 21827 -88
+ Misses 2087 2086 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
The changes look good to me. How did you access the correctness of fast_hgt_conv
?
@rusty1s lmk if anything else needed to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
Can we add an additional test where one of the node types is not a dst node type.
Currently all our tests are on the graph with node type author
and paper
and both author
and paper
are dst node types. We could add a new tests with node types author
, paper
, university
and have university
not be a dst node type. This will test L214 in hgt_conv
much better.
thanks for approving @wsad1, i will merge this and add additional testing in a sep PR |
we have proven its correctness and speed, lmk if anything else needed to merge fasthgt->hgt