Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing HGTConv with FastHGTConv #7117

Merged
merged 18 commits into from
Apr 12, 2023
Merged

Replacing HGTConv with FastHGTConv #7117

merged 18 commits into from
Apr 12, 2023

Conversation

puririshi98
Copy link
Contributor

we have proven its correctness and speed, lmk if anything else needed to merge fasthgt->hgt

@puririshi98 puririshi98 requested a review from rusty1s April 4, 2023 16:19
@github-actions github-actions bot added the nn label Apr 4, 2023
@rusty1s rusty1s changed the title removing fasthgt Replacing HGTConv with FastHGTConv Apr 4, 2023
@github-actions github-actions bot added the utils label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #7117 (ea043ee) into master (340d8b9) will decrease coverage by 0.03%.
The diff coverage is 98.90%.

@@            Coverage Diff             @@
##           master    #7117      +/-   ##
==========================================
- Coverage   91.30%   91.27%   -0.03%     
==========================================
  Files         437      436       -1     
  Lines       24002    23913      -89     
==========================================
- Hits        21915    21827      -88     
+ Misses       2087     2086       -1     
Impacted Files Coverage Δ
torch_geometric/nn/conv/__init__.py 100.00% <ø> (ø)
torch_geometric/nn/conv/hetero_conv.py 98.52% <92.85%> (-1.48%) ⬇️
torch_geometric/nn/conv/hgt_conv.py 98.21% <100.00%> (-1.79%) ⬇️
torch_geometric/utils/hetero.py 64.28% <100.00%> (+6.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
The changes look good to me. How did you access the correctness of fast_hgt_conv?

torch_geometric/nn/conv/hgt_conv.py Outdated Show resolved Hide resolved
@wsad1 wsad1 self-requested a review April 8, 2023 10:08
@puririshi98
Copy link
Contributor Author

@rusty1s lmk if anything else needed to merge

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.
Can we add an additional test where one of the node types is not a dst node type.
Currently all our tests are on the graph with node type author and paper and both author and paper are dst node types. We could add a new tests with node types author , paper , university and have university not be a dst node type. This will test L214 in hgt_conv much better.

@puririshi98
Copy link
Contributor Author

thanks for approving @wsad1, i will merge this and add additional testing in a sep PR

@puririshi98 puririshi98 merged commit 4b9cfe2 into master Apr 12, 2023
@puririshi98 puririshi98 deleted the fasthgt_2_hgt branch April 12, 2023 16:06
@wsad1 wsad1 mentioned this pull request Apr 28, 2023
rusty1s pushed a commit that referenced this pull request Apr 28, 2023
Removed reference to `FastHGTConv`. It was "merged" with `HGTConv`
[here](#7117)
rusty1s pushed a commit that referenced this pull request Oct 17, 2023
closes #8185

Background: #7117 replaces the previous `HGTConv` with an updated
implementation but kept the argument `group` in the docstring which
isn't used anymore. As only the documentation is touched, no further
testing is needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants