Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Coverage] models/dimenet.py #6781

Merged
merged 9 commits into from
Feb 24, 2023
Merged

[Code Coverage] models/dimenet.py #6781

merged 9 commits into from
Feb 24, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

Part of #6528, improves typing and code coverage for DimeNet.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #6781 (f592e0b) into master (e564ba5) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6781      +/-   ##
==========================================
+ Coverage   91.09%   91.36%   +0.26%     
==========================================
  Files         425      425              
  Lines       23097    22936     -161     
==========================================
- Hits        21041    20956      -85     
+ Misses       2056     1980      -76     
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet.py 99.67% <100.00%> (+32.24%) ⬆️
torch_geometric/visualization/graph.py 68.25% <0.00%> (-26.99%) ⬇️
torch_geometric/nn/conv/utils/typing.py 83.75% <0.00%> (-15.00%) ⬇️
torch_geometric/nn/pool/asap.py 91.89% <0.00%> (-8.11%) ⬇️
torch_geometric/nn/dense/linear.py 88.97% <0.00%> (-5.92%) ⬇️
torch_geometric/nn/models/attentive_fp.py 95.83% <0.00%> (-4.17%) ⬇️
torch_geometric/sampler/neighbor_sampler.py 91.56% <0.00%> (-3.22%) ⬇️
torch_geometric/io/tu.py 90.80% <0.00%> (-2.30%) ⬇️
torch_geometric/transforms/virtual_node.py 93.47% <0.00%> (-2.18%) ⬇️
torch_geometric/nn/models/basic_gnn.py 89.26% <0.00%> (-1.70%) ⬇️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SauravMaheshkar SauravMaheshkar marked this pull request as ready for review February 23, 2023 17:11
@SauravMaheshkar
Copy link
Contributor Author

@rusty1s it seems like shifting from " to ' has somehow lead to error with coverage patch. How do you suggest we proceed ?

@rusty1s
Copy link
Member

rusty1s commented Feb 24, 2023

Will look into. I think you should disable black though, we are not using it in PyG and the diffs can get a bit annoying :)

@rusty1s rusty1s merged commit d336d13 into pyg-team:master Feb 24, 2023
@SauravMaheshkar
Copy link
Contributor Author

Will look into. I think you should disable black though, we are not using it in PyG and the diffs can get a bit annoying :)

Yes ofcourse, will disable black globally on my system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants