Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NeighborSampler to be input-type agnostic #6173

Merged
merged 13 commits into from
Dec 7, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Dec 7, 2022

No description provided.

@github-actions github-actions bot added the data label Dec 7, 2022
@rusty1s rusty1s changed the title [WIP] Refactor NeighborSampler to be input-type agnostic Refactor NeighborSampler to be input-type agnostic Dec 7, 2022
@rusty1s rusty1s marked this pull request as ready for review December 7, 2022 18:15
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #6173 (9603aa5) into master (15b7a4c) will increase coverage by 0.00%.
The diff coverage is 93.38%.

@@           Coverage Diff           @@
##           master    #6173   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files         366      366           
  Lines       20559    20544   -15     
=======================================
- Hits        17346    17335   -11     
+ Misses       3213     3209    -4     
Impacted Files Coverage Δ
torch_geometric/data/lightning/datamodule.py 55.76% <ø> (-0.15%) ⬇️
torch_geometric/loader/hgt_loader.py 100.00% <ø> (ø)
torch_geometric/loader/link_neighbor_loader.py 100.00% <ø> (ø)
torch_geometric/loader/link_loader.py 76.71% <61.53%> (ø)
torch_geometric/sampler/neighbor_sampler.py 66.53% <95.45%> (-0.27%) ⬇️
torch_geometric/loader/node_loader.py 87.35% <100.00%> (-0.29%) ⬇️
torch_geometric/loader/utils.py 83.33% <100.00%> (-0.86%) ⬇️
torch_geometric/sampler/__init__.py 100.00% <100.00%> (ø)
torch_geometric/sampler/base.py 95.77% <100.00%> (+2.02%) ⬆️
torch_geometric/sampler/hgt_sampler.py 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 3413d9a into master Dec 7, 2022
@rusty1s rusty1s deleted the disentangle_input_type branch December 7, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant